GH4331/GH4349: Migrate GHA Artifact to V4 API #4350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devlead
commented
Sep 30, 2024
devlead
commented
- fixes GitHubActionCommand UploadArtifact is not using the latest @v4 Version. #4331
- fixes GitHubActionCommand DownloadArtifact is not using the latest @v4 Version #4349
devlead
force-pushed
the
feature/gh-4349/gh-4331
branch
from
3f195e8
to
88493f4
Compare
|
@cake-build/cake-team this should be ready for review, integration tests no longer cause warnings like this Upload / Download artifact is completely rewritten for the new v4 APIs but public Cake Common APIs/Aliases remain the same and integration tests look to generate same set of artifacts Previous: https://github.com/cake-build/cake/actions/runs/11092875166#artifacts The sizes are now correct previously it reported the uncompressed size, and uploads are noticeably faster. |
devlead
force-pushed
the
feature/gh-4349/gh-4331
branch
from
88493f4
to
40a9311
Compare
devlead
force-pushed
the
feature/gh-4349/gh-4331
branch
from
40a9311
to
2a6260f
Compare
gep13
reviewed
Oct 4, 2024
|
@devlead thank you for getting this done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.